Repository navigation
Fix malformed SupportedOSPlatform attribute from wrapped csproj lines (release/4.1) - #1781
Merged
Merged
Conversation
Backport of the fix on master: line-wrapping SupportedOSPlatformVersion/ TargetPlatformMinVersion split the tag from its value, and MSBuild preserved the leading newline+indent verbatim. That whitespace got baked into the compiled [assembly: SupportedOSPlatform(...)] attribute (e.g. "Android\r\n 24.0" instead of "android24.0"), which breaks Roslyn's/ Rider's platform-compat version parsing and causes spurious CA1416 warnings for every consumer calling into Couchbase.Lite, even when their own min-version matches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
pasin
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #1780 to
release/4.1.SupportedOSPlatformVersion/TargetPlatformMinVersioninCouchbase.Lite.csprojwere line-wrapped (tag+Condition on one line, value on the next). MSBuild does not trim that leading newline/indentation from the property value.GenerateAssemblyInfotarget into the compiled[assembly: SupportedOSPlatform(...)]attribute — e.g."Android\r\n 24.0"instead of"android24.0".CA1416warnings, even when their ownSupportedOSPlatformVersionmatches exactly.Test plan
net10.0-androidtarget, decompile the resultingCouchbase.Lite.dll, confirm theSupportedOSPlatformattribute string has no embedded whitespace🤖 Generated with Claude Code